Why are the ESLint rules in the pipedream repo linting common files?

This topic was automatically generated from Slack. You can find the original thread here.

Sergio Rodriguez : I’ve been trying to get set a new PR for Trello actions, but keeps failing due to ESLint, saying it expects certain required metadata. I noticed this is being requested in files that are common to the components, such as a common filef or actions, or a common-webhook for sources. Is this expected?

Dylan Sather (Pipedream) : thanks I just pushed these changes, and this is a good find, I’m pushing a fix and I’ll let you know when it’s out

Sergio Rodriguez : thanks, i’ll look forward!

Dylan Sather (Pipedream) : Can you merge latest master into your branch, then try committing a small change and push again

Dylan Sather (Pipedream) : Your editor (and GitHub) should no longer complain about those specific rules for any common*.js files

Sergio Rodriguez : ok checking now brb

Sergio Rodriguez : it didn’t complain with common*.js files

Sergio Rodriguez : but this pr for trello have a file board-based.js

Sergio Rodriguez :

Sergio Rodriguez : should this be added to the spell checker, or is it better that I rename this file with a leading common prefix. i didn’t do the sources, but should’nt be much of an issue updating hte references

Dylan Sather (Pipedream) : I’d recommend always keeping common files with the common*.js format so that it’s also easy for us to identify them. In this case I would just rename to common-board-based.js

Sergio Rodriguez : ok, i’ll make the change